Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change running tests, on Windows, from Chrome to Firefox #9233

Closed
wants to merge 2 commits into from
Closed

Change running tests, on Windows, from Chrome to Firefox #9233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1458f79
Change running tests on Windows from Chrome to Firefox
Falke-Design Jan 28, 2024
6d63fcd
Merge branch 'main' into fix/karma_windows_firefox
Falke-Design Jan 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Expand Up @@ -105,9 +105,8 @@ jobs:
- browser: Chrome1280x1024
- browser: FirefoxTouch
- browser: FirefoxNoTouch
- browser: FirefoxRetina
- browser: Chrome1280x1024
os: windows-latest
- browser: FirefoxRetina
- browser: Chrome1280x1024
os: macos-latest
- browser: SafariNative
Expand Down
3 changes: 2 additions & 1 deletion spec/karma.conf.js
View file
Open in desktop
Expand Up @@ -18,7 +18,8 @@ module.exports = function (/** @type {import('karma').Config} */ config) {
customContextFile: 'spec/context.html',
customDebugFile: 'spec/debug.html',
files: [
{pattern: 'node_modules/**', included: false, served: true},
{pattern: 'node_modules/ui-event-simulator/**/*.js', included: false, served: true},
{pattern: 'node_modules/prosthetic-hand/**/*.js', included: false, served: true},
Comment on lines +21 to +22
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why narrow this down? Also, doesn't prosthetic-hand include some assets that are not just JS?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied from @mourner #9231

{pattern: 'dist/**/*.js', included: false, served: true},
{pattern: 'dist/**/*.png', included: false, served: true},
{pattern: 'spec/setup.js', type: 'module'},
Expand Down