Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up Karma runner by narrowing down files Karma serves #9231

Merged
merged 1 commit into from Jan 29, 2024
Merged

Conversation

mourner
Copy link
Member

@mourner mourner commented Jan 26, 2024

  • Fix CI warnings about too many files open by excluding Karma from serving the whole of node_modules; this also seems to speed up CI runs, shaving off about a minute.
  • Skip requestAnimFrame test for now because it fails on Windows for mystery reasons Failing Windows job on CI due to requestAnimFrame test #9230 — at this moment it's more important to have a functioning CI that's not red all the time.

@mourner mourner requested a review from jonkoops January 26, 2024 14:29
@mourner
Copy link
Member Author

mourner commented Jan 26, 2024

Nope, now Windows fails on a different unrelated test. I'm stumped.

@mourner mourner changed the title CI fixes: speed up Karma runner and skip failing Windows test for now Speed up Karma runner by narrowing down files Karma serves Jan 29, 2024
@mourner mourner merged commit ea27b0f into main Jan 29, 2024
45 of 47 checks passed
@mourner mourner deleted the ci-fixes branch January 29, 2024 09:55
Copy link
Collaborator

@jonkoops jonkoops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants