Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added aria-label to Section variable #9116

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added aria-label to Section variable #9116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/control/Control.Layers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ export const Layers = Control.extend({
}, this);

if (!collapsed) {
section.setAttribute('aria-label', link.title);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why only do this when the layer is not collapsed? The visibility of an element should not necessarily influence the textual content, unless it's something explicitly related to announcing the visibility status.

this.expand();
}

Expand Down