Feature #9108 implemented. A scroll to top anchor tag added. #9111
Conversation
There was a problem hiding this comment.
This is a good start but there are a few things missing. Please checkout the must-have list: #9108 (comment)
And please make sure to only commit the relevant changes and don't change any formatting:
- Revert Gemfile.lock
- Revert blanks in v2.html
- Revert main.css
- Revert formatting in docs.js
… scrolls and hides automatically when scroll back up
|
I have added the screenshots in the previous commit. |
|
Changes made. Made the button response with screen size. |
docs/docs/css/main.css
Outdated
| &:hover{ | ||
| opacity: .5; | ||
| } |
There was a problem hiding this comment.
Please keep the classic css definition for now.
#backtotop:hover{
opacity: .5;
}
docs/docs/css/main.css
Outdated
| height: 26px; | ||
| right: .2em; | ||
| } | ||
| .backtotop{ |
There was a problem hiding this comment.
Please rename the class or the id. They should not have the same name
docs/_layouts/v2.html
Outdated
| <a class="ext-link github" href="http://github.com/Leaflet/Leaflet" title="View Source on GitHub"><img alt="View Source on GitHub" src="{{root}}docs/images/github-round.svg" width="46" /></a> | ||
| <a class="ext-link forum" href="https://stackoverflow.com/questions/tagged/leaflet" title="Ask for help on Stack Overflow"><img alt="Leaflet questions on Stack Overflow" src="{{root}}docs/images/forum-round.svg" width="46" /></a> | ||
| <div id="backtotop" class="ext-link"><div class="backtotop"></div></div> |
There was a problem hiding this comment.
I think it makes sense, to have this not in this <nav> element, because it is displayed at the bottom
There was a problem hiding this comment.
Yeah! Before it was just next to the nav elements. And then I re positioned it to the right bottom. I will re-position it to somewhere else.
… hoved changed back to regular
|
Hey i have made changes and requested a review. |
|
Fixes: #9108
Smooth scroll back to the top implemented for user convenience.