Add setInteractive
#9055
Open
Add setInteractive
#9055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Falke-Design Could you take a look at this? I had to publish a fork so my company's project could proceed, and I'd rather have it merged. Let me know if something is missing or isn't the best approach |
|
@Malvoz Any chance you could review this? I'm currently applying a patch, to use it at my company, and I'd rather move away from that |
|
Just chiming in that this feature would be useful 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5442
I'll note the I couldn't get the popup to trigger the event handler (
UIEventSimulator.fire('click', popup._container);). I'm also not sure if the line endings are correct, as I tried messing with that in many ways and some diffs show some^M, regardless of what I did