-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import Leaflet in tests using JavaScript modules #8936
Conversation
bcb468b
to
51509b4
Compare
Interesting, tests sometimes fail. I have no idea why yet, will look at it another time (gotta sleep). |
Looks like all the failures are timeouts — I guess browsers take to long to hop through all the imports and fetch everything. Also noting that the total test time jumps from <3m to 6–8m. We should look into addressing that before shipping — perhaps this alone would be enough to keep running against the bundle. It may also be beneficial because some issues may only manifest after bundling, which is how users end up using the code anyway, so tests closer to real world. |
How do you mean? We are currently still running the tests against the bundled code. Or are you referring to #8937? I am not quite sure what is causing the performance to regress so much, I'll have to take a look and investigate deeper. |
@jonkoops ah right, I missed that it's not yet implementing individual file import. But the regression is indeed suspicious — let's make sure it's not slower before we can land this. |
51509b4
to
29cb9aa
Compare
I'm closing this PR so that I can merge this work into a larger effort to start using Web Test Runner. See #8939 for more information. |
Changes the unit tests so they use the named exports from Leaflet loaded trough an import map.