Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Popup/Tooltip to use common code from DivOverlay #6639

Merged
merged 3 commits into from Jan 19, 2022
Merged

Refactor Popup/Tooltip to use common code from DivOverlay #6639

merged 3 commits into from Jan 19, 2022

Commits on Dec 21, 2021

  1. Refactor openPopup/Tooltip to use common functions [Map/Layer]\_initO… 

    …verlay
    johndoe committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    6d72f92 View commit details
    Browse the repository at this point in the history

  2. DivOverlay: common functions openOn/close 

    Refactor [Map\Layer] open/close-Popup/Tooltip to use DivOverlay's openOn/close
    johndoe committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    00d9ac7 View commit details
    Browse the repository at this point in the history

  3. DivOverlay: new public method toggle 

    Refactor Layer\ togglePopup/Tooltip: use common method DivOverlay\toggle

Popup: do not clear map._popup on close as it's redundant
    johndoe committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    d9238e2 View commit details
    Browse the repository at this point in the history