Explicitly remove controls from the map on map unload

[IvanSanchez]

This is a blind attempt (i.e. untested) to fix #6487. A map being destroyed will fire the unload event, and any controls from that map can use that event to remove themselves from the map.

[callumacrae]

Sweet, onRemove is being called now 👍

[callumacrae]

It looks like layers have the same problem (untested, just looked at the code) - should the same code be added there too?

[cherniavskii]

👍

[IvanSanchez]

Sweet, onRemove is being called now 👍

I'm more worried about the memory leaks - does this help?

It looks like layers have the same problem (untested, just looked at the code) - should the same code be added there too?

No need, because

Leaflet/src/map/Map.js

Lines 797 to 799 in 8108ff9

	for (i in this._layers) {
	this._layers[i].remove();
	}

[callumacrae]

I'm more worried about the memory leaks - does this help?

It helps in the example I posted, it doesn't help (measurably) in the actual application I'm working on - which probably just means the problem is somewhere else, probably outside of leaflet. I'll carry on investigating and keep you posted if I find anything else related to leaflet!

[IvanSanchez]

It helps in the example I posted,

That's good enough for me! 😄

[callumacrae]

Thanks for the quick fix!