Change running tests, on Windows, from Chrome to Firefox #9233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkoops
reviewed
Jan 28, 2024
Comment on lines
+21
to
+22
| {pattern: 'node_modules/ui-event-simulator/**/*.js', included: false, served: true}, | ||
| {pattern: 'node_modules/prosthetic-hand/**/*.js', included: false, served: true}, |
There was a problem hiding this comment.
Why narrow this down? Also, doesn't prosthetic-hand include some assets that are not just JS?
|
Chrome on Windows is probably the most used browser, so it doesn't feel good to not test on it (and Firefox usage is dying out from the other side). Not sure how to proceed here... Ideally we'd try to figure out why Chrome/Win is failing on CI first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the failing tests are more a problem of Chrome then of Windows. So I changed the browser to Firefox.
Fixes: #9230
and supersedes: #9231