Support for keyup/keydown for .on() events

[iamwyza]

How to reproduce

• Leaflet version I'm using:1.2
• Browser (with version) I'm using: Chrome 60
• OS/Platform (with version) I'm using: Win 10 1706
• map.on() doesn't supprot keydown/keyup

What behaviour I'm expecting and which behaviour I'm seeing

Because keypress doesn't register inputs that don't render characters, keypress doesn't work for things like backspace or escape.

Minimal example reproducing the issue

map.on('keypress', function() { console.log('pressed!'); });

[zivkaziv]

Hey, I would be happy to take this first issue:) If it's still open

[OrBin]

Hi, I've just submitted a PR (#6421) adding the requested feature.

[OrBin]

@iamwyza This issue can be closed since it has been implemented and now merged in #6421.

[volkanciloglu]

hi. I use the keypress event, but it just doesn't work when I press ctrl key. The disadvantage of using alphabetic and numeric keys.

[OrBin]

hi. I use the keypress event, but it just doesn't work when I press ctrl key. The disadvantage of using alphabetic and numeric keys.

That's exactly why we enabled binding keyup and keydown events. Just use those events to trigger whatever you want on Ctrl press.

[volkanciloglu]

I do not need this. I want to turn Drawing mode on and off by pressing a key.

[OrBin]

I see. It's not Leaflet that puts this limit - Ctrl key just doesn't trigger the keypress events on the browser, and that's why we enabled these events.
You can achieve your desire by binding keyup for Ctrl.