Added support for 'keydown' and 'keyup' events #6421
Conversation
There was a problem hiding this comment.
Hi, thanks for submitting this! 👍
Given that this looks like a change that possibly affects many existing application (potentially changing how we react to keyboard), I would really like to see some tests for this.
There are already quite a few tests that simulate keypress using happen, so I would assume you could do something similar. See in particular https://github.com/Leaflet/Leaflet/blob/9fda888df2791ca0df6f182a9d91d393ee49034c/spec/suites/map/handler/Map.KeyboardSpec.js
…constified the key codes used in the test file
|
I've added tests for |
|
👍 Good work with the tests, looks quite thorough. Again, thanks for submitting this (and sorry about taking way too long to follow up on your changes). |
* Added support for 'keydown' and 'keyup' events, as requested in issue Leaflet#5734 * Added tests for 'keydown', 'keypress' and 'keyup' events binding and constified the key codes used in the test file
Added support for 'keydown' and 'keyup' events, as requested in issue #5734