Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A more useful relative heat map #8

Closed
wants to merge 6 commits into from
Closed

Conversation

Guitlle
Copy link

@Guitlle Guitlle commented Apr 16, 2014

I believe it is more important to have a relative heatmap. This means that the maximum value in the visible points should be the hottest and the minimum should be the coolests. This is done by getting the maximum and the minimum and making it get a range and an offset.

@mweinelt
Copy link

Please implement this, it would make the heat maps so much more useful.

@marks
Copy link

marks commented Jun 11, 2014

+1

@doomsuckle
Copy link

Didn't I meet you at health datapalooza?

-----Original Message-----
From: "Mark Silverberg" notifications@github.com
Sent: ‎6/‎10/‎2014 5:35 PM
To: "Leaflet/Leaflet.heat" Leaflet.heat@noreply.github.com
Subject: Re: [Leaflet.heat] A more useful relative heat map (#8)

+1

Reply to this email directly or view it on GitHub.

@marks
Copy link

marks commented Jun 11, 2014

Yup!

Mark Silverberg http://SocialHealthInsights.comhttp://SocialHealthInsights.com
Sent from my iPhone

On Jun 11, 2014, at 12:08 AM, "doomsuckle" <notifications@github.commailto:notifications@github.com> wrote:

Didn't I meet you at health datapalooza?

-----Original Message-----
From: "Mark Silverberg" <notifications@github.commailto:notifications@github.com>
Sent: ?6/?10/?2014 5:35 PM
To: "Leaflet/Leaflet.heat" <Leaflet.heat@noreply.github.commailto:Leaflet.heat@noreply.github.com>
Subject: Re: [Leaflet.heat] A more useful relative heat map (#8)

+1

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com//pull/8#issuecomment-45699830.

@grotheandreas1
Copy link

Many thanks for your contribution, this is exactly what I was looking for!

There is an issue in '_redraw()' when calculating the min/max values, though:
An alt sequence of eg. [0, 10] would give a min value of '10' because 'if (min == false)' is 'true' in the second iteration ('0 == false' is 'true' in javascript). Perhaps an alternative approach would be to use 'var min=0, max=0; ... min=Math.min(min,value); max=Math.max(max,value))' instead?

@Guitlle
Copy link
Author

Guitlle commented Aug 22, 2014

Thanks grotheandreas1, I'll fix it

@danzel
Copy link
Member

danzel commented Aug 26, 2014

Use a === instead

@jbouzekri
Copy link

Hi everyone, it would be very useful to have a relative heat map.
@DuGuille will you be able to finish this ?

@Guitlle
Copy link
Author

Guitlle commented Apr 14, 2016

Hi jbouzekri. it's been a while since I posted this. I'll try to finish it this weekend.

@jbouzekri
Copy link

Many thanks !!!!

@spaasis
Copy link

spaasis commented May 7, 2016

@DuGuille Any update on the schedule? This would be an extremely nice feature

@Guitlle
Copy link
Author

Guitlle commented May 14, 2016

Hi. I've found a much better way of doing this. Made a new branch and a new pull request #58

@Guitlle Guitlle closed this May 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants