Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix osx root path issues #171

Merged
merged 3 commits into from Jan 5, 2023
Merged

Conversation

bradennapier
Copy link
Contributor

@bradennapier bradennapier commented Dec 15, 2022

fixes so all paths dont get rewritten to ../../../../../../../users/... on osx

fixes #167

I just edited the project using github editor so it wouldn't have styles and such - but this does fix the issue on my project and follows with what the solution was on #167 - figure it'd be ideal to just put this forward for you to merge if all looks well!

@nonara
Copy link
Collaborator

nonara commented Dec 16, 2022

Thank you! We'll wait a couple of days to see if OP responds, but this looks good to me.

Copy link

@nathtumlin-tanium nathtumlin-tanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches what we've been using locally that has been working

@bradennapier
Copy link
Contributor Author

Yep it working across our organization as well without issue

@bradennapier
Copy link
Contributor Author

@nonara anyh update here?

@nonara
Copy link
Collaborator

nonara commented Jan 5, 2023

Sorry for the delay. We hit some nasty issues with CI tests not working all of the sudden — memory fault with NodeJS. After I got it worked around holidays came.

Thank you for your help and input on this! I'm pushing it through.

@nonara nonara merged commit 6a2cb89 into LeDDGroup:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Paths needlessly go back to root on macOS
3 participants