New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds to raise exception to main caller thread from prefetch generator #412

Merged

jtsodapop merged 10 commits into develop from al-1280

Feb 7, 2022

Contributor

jtsodapop commented Feb 3, 2022

No description provided.


          adds to raise exception to main caller thread from prefetch generator

fbd4e63

github-actions bot added the active-learning label


          cleanup code

0531d0a

jtsodapop requested a review from msokoloff1

February 3, 2022 16:10

jtsodapop added 2 commits

February 3, 2022 11:48


          minor update to add join with start

fbc6f77


          reversion to original code + addition for non-multithread option

39927ca

Contributor Author

jtsodapop commented Feb 3, 2022

Hi @msokoloff1 updated the code to work for non-multithread. Code was changed under impression that errors will be noticed upon reaching into the generator's next item


          changes to test cases that were previously broken but we did not see it

b78d67b

msokoloff1 reviewed

View reviewed changes

labelbox/data/generator.py Outdated Show resolved Hide resolved

msokoloff1 reviewed

View reviewed changes

labelbox/data/serialization/labelbox_v1/converter.py Outdated Show resolved Hide resolved

msokoloff1 suggested changes

View reviewed changes

Contributor

msokoloff1 left a comment

Looks good. Just one small change requested

msokoloff1 reviewed

View reviewed changes

labelbox/data/generator.py Outdated Show resolved Hide resolved

msokoloff1 reviewed

View reviewed changes

labelbox/data/generator.py Outdated Show resolved Hide resolved


          updates to files to remove multithread param and instead just set bas…

40973e8

…ed on num exec

jtsodapop requested a review from msokoloff1

February 4, 2022 15:55

msokoloff1 reviewed

View reviewed changes

labelbox/data/generator.py Outdated Show resolved Hide resolved

msokoloff1 reviewed

View reviewed changes

labelbox/data/generator.py Show resolved Hide resolved

jtsodapop added 2 commits

February 4, 2022 11:36


          small update to move prefetch gen to only if we have multithread

722194b


          update to tox requirements so that it uses non-latest pytest to work …

6b6a049

…with pytest-cases

Contributor Author

jtsodapop commented Feb 4, 2022 •

edited

Latet pytest update released on 2-3-2022 broke compatibility with pytest-cases. Some file changes are to accommodate some deprecations along with using an older version of pytest to continue testing until the issue is resolved.

Issue can be found and tracked here: smarie/python-pytest-cases#251

jtsodapop requested a review from msokoloff1

February 4, 2022 19:49

jtsodapop added 2 commits

February 7, 2022 09:51


          small update

0ac7ee8


          updates to generator and also add test cases

47bf08d

msokoloff1 approved these changes

View reviewed changes

jtsodapop merged commit 718e78e into develop

jtsodapop deleted the al-1280 branch

February 7, 2022 17:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment