Add orThrow and orDefault methods to Index #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Machine-Maker
changed the title
zml2008
approved these changes
Apr 2, 2022
zml2008
requested changes
Apr 2, 2022
|
addressed those requested changes and the check style errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds orThrow and orDefault methods to Index. It was kind of annoying how Index#key and Index#value were marked as Nullable when in certain situations you know that they won't return nullable. Like
NamedTextColor.NAMES.key(NamedTextColor.RED). These orThrow methods are just helpers to avoid wrapping calls in requireNonNulls or ignoring warnings.Also added orDefault methods since that's a common map need.