Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(minimessage): selector tag #737

Merged
merged 5 commits into from Jun 1, 2022
Merged

feat(minimessage): selector tag #737

merged 5 commits into from Jun 1, 2022

Conversation

NoahvdAa
Copy link
Contributor

@NoahvdAa NoahvdAa commented Mar 30, 2022 •
edited

Adds a tag for SelectorComponents (part of #678):

Example usage:

<sel:@a/>
<selector:@s/>

@kezz kezz added this to the 4.11.0 milestone Mar 30, 2022
@MiniDigger
Copy link
Member

(docs PR please)

looking good

kezz
kezz requested changes Mar 31, 2022
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for an equiv docs PR, but otherwise, this LGTM! Thank you :)

@zml2008 zml2008 mentioned this pull request May 20, 2022
Merged
zml2008
zml2008 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@zml2008 zml2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs PR now present

@NoahvdAa
Copy link
Contributor Author

Sorry for not making a docs PR, I completely forgot. The separator has been added.

@zml2008 zml2008 self-assigned this Jun 1, 2022
@zml2008 zml2008 merged commit ff95e34 into KyoriPowered:main/4 Jun 1, 2022
@NoahvdAa NoahvdAa deleted the feat/mm-selectortag branch June 1, 2022 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezz kezz kezz requested changes

@zml2008 zml2008 zml2008 approved these changes

Assignees

@zml2008 zml2008

Labels
area: text-minimessage type: enhancement
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@NoahvdAa @MiniDigger @zml2008 @kezz