fix negative number parsing for positions #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
reviewed
Mar 22, 2022
api/src/test/java/net/kyori/adventure/text/BlockNBTComponentTest.java
Outdated
Show resolved
Hide resolved
Machine-Maker
force-pushed
the
fix/negative-positions
branch
from
1e39d57
to
b2a00d6
Compare
kezz
approved these changes
Mar 30, 2022
kashike
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing of positions failed to account for negative numbers which according to Minecraft's parsing of these positions should be accounted for.