Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text-minimessage: Limit characters allowed in tag names #717

Merged
merged 2 commits into from Feb 28, 2022
Merged

text-minimessage: Limit characters allowed in tag names #717

merged 2 commits into from Feb 28, 2022

Conversation

kezz
Copy link
Member

@kezz kezz commented Feb 28, 2022

Limits tag names to the pattern [!?#]?[a-z0-9_-]*.

Or, in plain text:

Tag names must only contain the characters a-z, 0-9, _, and -. They can also optionally start with any of the following characters: !?#.

@kezz kezz added this to the 4.10.0 milestone Feb 28, 2022
MiniDigger
MiniDigger requested changes Feb 28, 2022
View reviewed changes
Copy link
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delaying release for docs PR!

@kezz kezz requested a review from MiniDigger February 28, 2022 19:15
@kezz
Copy link
Member Author

kezz commented Feb 28, 2022

See linked docs PR: KyoriPowered/adventure-docs#68.

@kezz kezz mentioned this pull request Feb 28, 2022
Merged
@zml2008 zml2008 merged commit 24ae3af into main/4 Feb 28, 2022
@zml2008 zml2008 deleted the fix/restrict-tag-names branch February 28, 2022 19:57
This was referenced Feb 28, 2022
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Open
Merged
This was referenced Feb 28, 2022
Merged
Merged
Open
Open
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
This was referenced Mar 3, 2022
Closed
Merged
@renovate renovate bot mentioned this pull request Mar 4, 2022
Merged
1 task
This was referenced Mar 14, 2022
Closed
Closed
This was referenced Apr 13, 2022
Merged
Merged
This was referenced May 9, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiniDigger MiniDigger MiniDigger approved these changes

@rymiel rymiel rymiel approved these changes

Assignees
No one assigned
Labels
area: text-minimessage type: enhancement
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kezz @MiniDigger @rymiel @zml2008