New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
text-minimessage: Allow tags to be closed in one tag #707
Conversation
disregard the first part of that comment, |
To support vanilla components properly, I made all of the standard tags able to have children, since all component types can have children normally. The forced-no children attribute on Inserting tags is really just for custom things -- so there should probably be an attribute on the serializer to generate those sort of tags without the closing slash. The only situation where that's relevant in MM itself is probably the newline tag though, since that's theoretically serializable (though, due to compaction it often won't end up as a separate component). |
46e2f61
to
6649b5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Today i learned those components can have children in vanilla, sounds messy
This simplifies the language for tags with no children.