Rework the MiniMessage serializer to consolidate behavior into resolvers #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
requested changes
Feb 24, 2022
...src/main/java/net/kyori/adventure/text/minimessage/serializer/ArgumentQuotingPreference.java
Outdated
Show resolved
Hide resolved
...sage/src/main/java/net/kyori/adventure/text/minimessage/serializer/SerializableResolver.java
Show resolved
Hide resolved
...-minimessage/src/main/java/net/kyori/adventure/text/minimessage/serializer/package-info.java
Show resolved
Hide resolved
...-minimessage/src/test/java/net/kyori/adventure/text/minimessage/SerializerCollectorTest.java
Show resolved
Hide resolved
...ssage/src/test/java/net/kyori/adventure/text/minimessage/tag/standard/DecorationTagTest.java
Show resolved
Hide resolved
...inimessage/src/test/java/net/kyori/adventure/text/minimessage/MiniMessageSerializerTest.java
Outdated
Show resolved
Hide resolved
zml2008
force-pushed
the
feature/serializer
branch
from
02fe3f1
to
7d57823
Compare
MiniDigger
approved these changes
Feb 26, 2022
kezz
approved these changes
Feb 26, 2022
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this is only exposed internally, but after development in
future releases this may begin to be exposed more widely.
Fixes #513
Fixes #526
I've currently got the core of the system here, and all reproducible tags exposed to the serializer. Many tests fail due to differences in escaping and tag order. Much of this is subjective, and some will need reconciling with the quirks of the parser to ensure round-trippability of the whole system.
I would like review on this to be focused on correctness and style of the generated output, and API exposed on
MiniMessageinstances. API design review for the serialization system itself can be provided, but beyond small issues or complete blockers, I would like to delay discussion on the structure of the serialization API until after 4.10.0 has been released. All of the serialization system is internal API that is still subject to change, and it will likely change as we refine it later on. Design discussion is welcome in #702.