Add a new tag for line breaks (<br>) #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
approved these changes
Feb 20, 2022
kezz
requested changes
Feb 20, 2022
...-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/NewLineTag.java
Outdated
Show resolved
Hide resolved
...-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/NewLineTag.java
Outdated
Show resolved
Hide resolved
...-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/NewLineTag.java
Outdated
Show resolved
Hide resolved
Not sure about a new alias like that. |
|
The majority of MiniMessage users will not be familiar with HTML. I do not see how adding a clearer tag would cause any more confusion. |
...inimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/StandardTags.java
Outdated
Show resolved
Hide resolved
|
I think |
Joo200
force-pushed
the
feature/linebreak
branch
from
2c7b212
to
9bb3a3e
Compare
zml2008
approved these changes
Feb 21, 2022
kezz
requested changes
Feb 21, 2022
...-minimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/NewlineTag.java
Outdated
Show resolved
Hide resolved
...inimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/StandardTags.java
Outdated
Show resolved
Hide resolved
...inimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/StandardTags.java
Outdated
Show resolved
Hide resolved
...inimessage/src/main/java/net/kyori/adventure/text/minimessage/tag/standard/StandardTags.java
Outdated
Show resolved
Hide resolved
kezz
approved these changes
Feb 21, 2022
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous problem is here #686 :
Sometimes it's not possible or a bad idea to use
\nfor a line break. Maybe your message storage doesn't support that (or you'd have to escape it there).With this PR I want to add a
<br>tag as alternative to \n. It'll replace<br>with the Component for a new line.