Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Internal configuration #650

Merged
merged 1 commit into from Feb 5, 2022
Merged

Conversation

kashike
Copy link
Member

@kashike kashike commented Dec 21, 2021

No description provided.

@kashike kashike requested a review from kezz December 22, 2021 01:33
@kashike kashike linked an issue Feb 4, 2022 that may be closed by this pull request
@kashike kashike force-pushed the feature/internal-config branch 2 times, most recently from 8e4ccf3 to ac68e2b Compare February 4, 2022 07:26
@kashike kashike requested a review from zml2008 February 4, 2022 07:26
Copy link
Member

@zml2008 zml2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm assuming checks pass

This was referenced Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract system property name creation to a shared method
4 participants