New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: Introduce Component.textOfChildren as a replacement for TextComponent.ofChildren #617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't make sense. Why not add/undeprecate one of the methods on Component
? Why is TextComponent
the only component that gets a constructor method in the interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh didn't spot this was actually on Component
:p
43993ad
to
08fa6e2
Compare
…onent.ofChildren This indirectly reverts commit 9ffba5b.
08fa6e2
to
51e1cd4
Compare
This indirectly reverts commit 9ffba5b.