Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Introduce Component.textOfChildren as a replacement for TextComponent.ofChildren #617

Merged
merged 1 commit into from Dec 19, 2021

Conversation

kashike
Copy link
Member

@kashike kashike commented Nov 29, 2021

This indirectly reverts commit 9ffba5b.

Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't make sense. Why not add/undeprecate one of the methods on Component? Why is TextComponent the only component that gets a constructor method in the interface?

Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh didn't spot this was actually on Component :p

@kashike kashike self-assigned this Dec 19, 2021
…onent.ofChildren

This indirectly reverts commit 9ffba5b.
@kashike kashike merged commit ff8cd3d into master Dec 19, 2021
@kashike kashike deleted the feature/text-adoption-agency branch December 19, 2021 22:06
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants