Add standard join configurations #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
requested changes
Oct 24, 2021
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
lynxplay
force-pushed
the
feature/standard-join-configurations
branch
from
edd71d8
to
ee77198
Compare
lynxplay
force-pushed
the
feature/standard-join-configurations
branch
from
ee77198
to
4e565d4
Compare
|
I wonder what would be more expected; |
kezz
requested changes
Oct 24, 2021
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
|
Maybe providing both options is the best way to go ? E.g. instead of |
lynxplay
force-pushed
the
feature/standard-join-configurations
branch
from
4e565d4
to
8e2042e
Compare
|
Added the |
|
Hmmm.. Maybe just the one method with a boolean parameter for a space? |
Yea would have been my second guess 👍 I'll stick to that then :) |
kezz
requested changes
Oct 24, 2021
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
api/src/main/java/net/kyori/adventure/text/JoinConfiguration.java
Outdated
Show resolved
Hide resolved
lynxplay
force-pushed
the
feature/standard-join-configurations
branch
from
8e2042e
to
2987ef9
Compare
|
Updated the additions to a |
lynxplay
force-pushed
the
feature/standard-join-configurations
branch
from
2987ef9
to
4368f68
Compare
While using join configurations is already rather simple, they tend to clutter up already rather verbose source code. While the initial creation of the JoinConfiguration already included a null configuration, accessible through 'JoinConfiguration#noSeparators', other standards or often used layouts were not added. This commit adds three more defaults/standards to the join configuration implementation that are exposed through static accessors in the join configuration interface. Specifically: newLines: A straight forward instance of the join configuraiton that uses the new line component to join together components. commas: Another straight forward instance of the join configuration that uses a single comma (or potentially a comma and a space) to join together components. arrayLike: A more complex join configuration that recreates the layout used by the java.util.Arrays#toString method. Resolves: KyoriPowered#466
lynxplay
force-pushed
the
feature/standard-join-configurations
branch
from
4368f68
to
5d4384a
Compare
zml2008
approved these changes
Nov 18, 2021
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using join configurations is already rather simple, they tend to
clutter up already rather verbose source code. While the initial
creation of the JoinConfiguration already included a null configuration,
accessible through 'JoinConfiguration#noSeparators', other standards or
often used layouts were not added.
This commit adds three more defaults/standards to the join configuration
implementation that are exposed through static accessors in the join
configuration interface.
Specifically:
newLines:
A straight forward instance of the join configuraiton that uses the
new line component to join together components.
commas:
Another straight forward instance of the join configuration that uses
a single comma to join together components, creating a CSV like
layout.
arrayLike:
A more complex join configuration that recreates the layout used by
the java.util.Arrays#toString method.
Resolves: #466
Pretty open about suggestions for the
arrayLikemethod name.If others have more suggestions for often used standard styling (tho
arrayLikeandnewLinesare by far my most used ones) I'd be happy to implement them in the context of this PR as well.