extra-kotlin: Added more extensions and enabled explicit API #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
reviewed
Oct 19, 2021
extra-kotlin/src/main/kotlin/net/kyori/adventure/extra/kotlin/HSVLikeExtensions.kt
Outdated
Show resolved
Hide resolved
|
Alright then, I'll save them for later. |
|
I think that the Kotlin version we expose was left on 1.4 to avoid any breaking changes for those who transitively depend on Kotlin through this module. @zml2008 could confirm this as they touched that last. |
|
that's correct - you can bump the plugin version, but not the language version or stdlib dependency version |
kezz
approved these changes
Nov 1, 2021
zml2008
approved these changes
Nov 7, 2021
This was referenced Feb 28, 2022
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cloned branch from #338 because I deleted the fork with the original branch in it.
As mentioned in the original, this adds some more nice extensions to the extra-kotlin module, and enables Kotlin's explicit API feature.
I do plan to add a couple more extensions to this, now I've thought about it, but I will mark it as ready when I've done that.