Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StyleImpl DRY (#392) #461

Merged
merged 11 commits into from May 21, 2022
Merged

StyleImpl DRY (#392) #461

merged 11 commits into from May 21, 2022

Conversation

emilyy-dev
Copy link
Contributor

Reduces code repetition in StyleImpl by implementing a DecorationMap, a Map<TextDecoration, TextDecoration.State> that operates on bit flags.

Closes #392

kezz
kezz requested changes Oct 3, 2021
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicks, but I do like the overall PR!

api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/DecorationMap.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/Style.java Show resolved Hide resolved
emilyy-dev
emilyy-dev commented Oct 3, 2021
View reviewed changes
Copy link
Contributor Author

@emilyy-dev emilyy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re kezz

api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/Style.java Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/DecorationMap.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/DecorationMap.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Outdated Show resolved Hide resolved
api/src/main/java/net/kyori/adventure/text/format/StyleImpl.java Show resolved Hide resolved
@emilyy-dev emilyy-dev requested a review from kezz October 3, 2021 03:42
@emilyy-dev emilyy-dev requested a review from kezz October 8, 2021 03:43
kezz
kezz approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks for the PR :)

@zml2008 zml2008 added this to the 4.10.0 milestone Dec 11, 2021
@zml2008 zml2008 modified the milestones: 4.10.0, 4.11.0 Dec 11, 2021
@emilyy-dev
Copy link
Contributor Author

rebased

@zml2008 zml2008 merged commit 662fe1a into KyoriPowered:main/4 May 21, 2022
@zml2008 zml2008 self-assigned this May 21, 2022
@emilyy-dev emilyy-dev deleted the styleimpl-dry branch March 19, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell left review comments

@zml2008 zml2008 zml2008 approved these changes

@kezz kezz kezz approved these changes

Assignees

@zml2008 zml2008

Labels
area: api type: enhancement
Projects
None yet
Milestone
4.11.0
Development

Successfully merging this pull request may close these issues.

Reduce duplication in StyleImpl
4 participants
@emilyy-dev @zml2008 @kezz @SirYwell