Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: Rename Title.Times.of #449

Merged
merged 3 commits into from Sep 25, 2021
Merged

api: Rename Title.Times.of #449

merged 3 commits into from Sep 25, 2021

Conversation

NoahvdAa
Copy link
Contributor

Fixes #448.

@NoahvdAa NoahvdAa changed the title api: Rename Title.Times.of (#448) api: Rename Title.Times.of Sep 21, 2021
kezz
kezz requested changes Sep 21, 2021
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This PR should however also replace all usages of the now deprecated method in the codebase.

api/src/main/java/net/kyori/adventure/title/Title.java Show resolved Hide resolved
@NoahvdAa NoahvdAa requested a review from kezz September 21, 2021 15:02
kezz
kezz approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR :)

@kezz kezz added this to the 4.10.0 milestone Sep 22, 2021
@zml2008 zml2008 merged commit 71061df into KyoriPowered:master Sep 25, 2021
@zml2008 zml2008 self-assigned this Sep 25, 2021
This was referenced Feb 28, 2022
Merged
Merged
Closed
Merged
Merged
Closed
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
This was referenced Feb 28, 2022
Merged
Open
Open
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
This was referenced Mar 14, 2022
Closed
Closed
This was referenced Apr 13, 2022
Merged
Merged
This was referenced May 9, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Proximyst Proximyst Proximyst left review comments

@zml2008 zml2008 zml2008 approved these changes

@kezz kezz kezz approved these changes

Assignees

@zml2008 zml2008

Labels
area: api type: enhancement
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.

Rename Title.Times.of
4 participants
@NoahvdAa @zml2008 @kezz @Proximyst