Add decorations(Map) to component/style builders #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
requested changes
Sep 13, 2021
api/src/main/java/net/kyori/adventure/text/ComponentBuilder.java
Outdated
Show resolved
Hide resolved
lynxplay
force-pushed
the
feature/component-builder-decoration-additions
branch
from
e96f5e6
to
fc5d0a4
Compare
Got you, thanks for the suggestions 👍 |
This commit introduces a new decorations method to the component and style builderthat takes in a map of text decorations and their state. This methodalready exists on the Component interface but was previously missing on the respective builders. As the style builder stores the decorations in individual fields and hence cannot natively work with the map layout, the method was implemented as a default method on the interface and simply delegates the map entriess to the normal decorate methods. The main motivation for the addition of this method is the easy application of a preset map of decorations.
lynxplay
force-pushed
the
feature/component-builder-decoration-additions
branch
from
fc5d0a4
to
db91520
Compare
lynxplay
changed the title
kashike
approved these changes
Oct 15, 2021
This was referenced Feb 28, 2022
Merged
Merged
Merged
This was referenced Feb 28, 2022
Merged
Merged
Merged
Merged
This was referenced Mar 14, 2022
This was referenced Apr 13, 2022
This was referenced May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a new decorations method to the component and
style builderthat takes in a map of text decorations and their state.
This methodalready exists on the Component interface but was
previously missing on the respective builders.
As the style builder stores the decorations in individual fields and
hence cannot natively work with the map layout, the method was
implemented as a default method on the interface and simply delegates
the map entriess to the normal decorate methods.
The main motivation for the addition of this method is the easy
application of a preset map of decorations.
I followed the current precedence of stating that the mutation modifies the "component" instead of the builder as that seems to be the current practice in all other decoration related methods on the interface.