api: Make contains check for entity name #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezz
force-pushed
the
make-contains-check-entities
branch
from
042b886
to
192de12
Compare
|
Rebased following merge of #364. |
kezz
force-pushed
the
make-contains-check-entities
branch
from
192de12
to
506c3dc
Compare
kashike
requested changes
May 17, 2021
kezz
force-pushed
the
make-contains-check-entities
branch
from
506c3dc
to
abbbb63
Compare
kashike
approved these changes
May 21, 2021
kashike
added
area: api
type: enhancement
type: bug
and removed
type: enhancement
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
Component#contains(Component)to check for the name of an entity in aShowEntityhover event and adds some tests.