ComponentSerializer services #343
Conversation
kashike
force-pushed
the
feature/component-services
branch
from
169ccd2
to
b6ba19f
Compare
...gacy/src/main/java/net/kyori/adventure/text/serializer/legacy/LegacyComponentSerializer.java
Show resolved
Hide resolved
...in/src/main/java/net/kyori/adventure/text/serializer/plain/PlainTextComponentSerializer.java
Show resolved
Hide resolved
kashike
force-pushed
the
feature/component-services
branch
2 times, most recently
from
e14baae
to
00d458c
Compare
kashike
force-pushed
the
feature/component-services
branch
from
1f891ce
to
cea0a30
Compare
kashike
force-pushed
the
feature/component-services
branch
from
cea0a30
to
3abfebc
Compare
kashike
force-pushed
the
feature/component-services
branch
from
3abfebc
to
4a984c1
Compare
There was a problem hiding this comment.
As I understand, this could change the way certain component serializers are configured, possibly in a way that is not reversible by the API user.
I assume this isn't considered a breaking change for the static helper methods - GsonComponentSerializer.gson(), colorDownsamplingGson(), LegacyComponentSerializer.legacySection(), legacyAmpersand(), and the like - because the exact configuration of those serializers is not specified. (Though perhaps this lack of exact requirements could be documented)
For LegacyComponentSerializer.builder(), however, the component service has the ability to touch the builder before anything happens to it. This could mean that certain options on the LegacyComponentSerializer could be set by the service, but not unset by the user. For example, useUnusualXRepeatedCharacterHexFormat has no method to undo it.
| @@ -471,6 +488,7 @@ private void applyFullFormat() { | |||
| private ComponentFlattener flattener = ComponentFlattener.basic(); | |||
|
|
|||
| BuilderImpl() { | |||
| BUILDER.accept(this); // let service provider touch the builder before anybody else touches it | |||
There was a problem hiding this comment.
Specifically this change could irreversibly affect behavior.
There was a problem hiding this comment.
This only provides defaults - anything can be changed by using the builder methods like normal.
Correct - not considered a breaking change.
This is true - we could introduce a method to allow this. But as is currently, no platforms do anything except providing the default |
kashike
force-pushed
the
feature/component-services
branch
from
4a984c1
to
5aec9f1
Compare
kashike
force-pushed
the
feature/component-services
branch
from
5aec9f1
to
bb6be19
Compare
No description provided.