api: More ways to stop sound #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
previously requested changes
Apr 9, 2021
kashike
reviewed
Apr 16, 2021
|
Renamed and rebased :) |
zml2008
approved these changes
Jun 6, 2021
kashike
requested changes
Jun 7, 2021
zml2008
force-pushed
the
stop-specific-sound
branch
from
ed4ada6
to
af6f2e8
Compare
This was referenced Jun 8, 2021
Closed
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following methods that simplify the process of manipulating sounds.
Audience#stopSound(Sound)Allows developers to stop specific sounds without creating a `SoundStop.
Sound#stopperGets a
SoundStopthat will stop the sound.SoundStop#sound(Sound)Gets a
SoundStopthat will stop a specific sound.