api: Expose ComponentLike -> Component conversion method #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashike
force-pushed
the
feature/expose-clc
branch
from
76c0f0d
to
302fe77
Compare
kashike
force-pushed
the
feature/expose-clc
branch
2 times, most recently
from
cbcf57f
to
facc2f4
Compare
octylFractal
approved these changes
May 13, 2021
| components.trimToSize(); | ||
| } | ||
| // if we filtered all elements out, just use an empty list instead | ||
| if(components == null || components.isEmpty()) return Collections.emptyList(); |
There was a problem hiding this comment.
Isn't the latter half of this condition impossible?
kashike
force-pushed
the
feature/expose-clc
branch
from
facc2f4
to
2c13c67
Compare
This was referenced Jun 8, 2021
Closed
Merged
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.