Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: TextColor.lerp #215

Merged
merged 2 commits into from Jun 7, 2021
Merged

api: TextColor.lerp #215

merged 2 commits into from Jun 7, 2021

Conversation

kashike
Copy link
Member

@kashike kashike commented Nov 27, 2020

No description provided.

@kashike kashike added this to the 4.3.0 milestone Nov 27, 2020
@kashike kashike modified the milestones: 4.3.0, 4.4.0 Dec 4, 2020
@zml2008 zml2008 modified the milestones: 4.4.0, 4.5.0 Jan 18, 2021
@zml2008 zml2008 modified the milestones: 4.5.0, 4.6.0 Feb 20, 2021
@zml2008 zml2008 modified the milestones: 4.6.0, 4.7.0 Mar 4, 2021
@zml2008
Copy link
Member

zml2008 commented Mar 5, 2021

this should be updated at some point to support lerping HSV colours as well.

@zml2008 zml2008 removed this from the 4.7.0 milestone Mar 8, 2021
@zml2008 zml2008 added this to the 4.8.0 milestone Jun 7, 2021
kezz
kezz approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@kezz kezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be worth adding some more tests (perhaps for t=0 and t=1) but it's just simple maths so might not be worth the effort. Looks great though!

@kashike kashike self-assigned this Jun 7, 2021
@kashike kashike merged commit ab4bd60 into master Jun 7, 2021
This was referenced Jun 8, 2021
Closed
Merged
Merged
@renovate renovate bot mentioned this pull request Jul 1, 2021
Merged
1 task
@kashike kashike deleted the feature/lerp branch September 21, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zml2008 zml2008 zml2008 left review comments

@Electroid Electroid Electroid requested changes

@kezz kezz kezz approved these changes

@MiniDigger MiniDigger MiniDigger approved these changes

Assignees

@kashike kashike

Labels
area: api type: enhancement
Projects
None yet
Milestone
4.8.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kashike @zml2008 @kezz @MiniDigger @Electroid