Merge pull request #647 from KingOfSquares/range-check

util: Add a range check for HSVLike

api/src/main/java/net/kyori/adventure/util/HSVLikeImpl.java

@@ -33,6 +33,9 @@ final class HSVLikeImpl implements HSVLike {
   private final float v;
 
   HSVLikeImpl(final float h, final float s, final float v) {
+    requireInsideRange(h, "h");
+    requireInsideRange(s, "s");
+    requireInsideRange(v, "v");
     this.h = h;
     this.s = s;
     this.v = v;
@@ -53,6 +56,13 @@ public float v() {
     return this.v;
   }
 
+  private static void requireInsideRange(final float number, final String name) throws IllegalArgumentException {
+    if (number < 0 || 1 < number) {
+      throw new IllegalArgumentException(
+        name + " (" + number + ")" + " is not inside the required range: [0,1]");
+    }
+  }
+
   @Override
   public boolean equals(final @Nullable Object other) {
     if (this == other) return true;

api/src/test/java/net/kyori/adventure/util/HSVLikeTest.java

@@ -32,7 +32,9 @@
 import org.junit.jupiter.api.Test;
 
 import static org.junit.jupiter.api.Assertions.assertArrayEquals;
+import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 class HSVLikeTest {
   @Test
@@ -64,4 +66,16 @@ private static float[] roundFloats(final float @NotNull [] floats) {
     }
     return result;
   }
+
+  @Test
+  void testRange() {
+    assertThrows(IllegalArgumentException.class, () -> HSVLike.of(2, 1, 1));
+    assertThrows(IllegalArgumentException.class, () -> HSVLike.of(1, -1, 1));
+    assertThrows(IllegalArgumentException.class, () -> HSVLike.of(1, 1, 2));
+    assertDoesNotThrow(() -> {
+      HSVLike.of(1, 1, 1);
+      HSVLike.of(0, 0, 0);
+      HSVLike.of(0.5f, 0.5f, 0.5f);
+    });
+  }
 }