fix: Try-catch around constructing placeholders #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymiel
changed the title
kezz
requested changes
Mar 5, 2022
|
Didn't want to cause an error as that would block other placeholders from being used, plus I also wanted to add some logic directly to the placeholders input to specifically point out the invalid placeholder, but that's more frontend work |
kezz
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #87
Ugly code but this at least preserves all other placeholders while filtering out the invalid ones
Also replaces kotlin deprecated
minutes(Int): DurationwithInt.minutes extension property from Duration.Companion