platform-bukkit: fix ViaVersion softDepend occurring too late #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zml2008
requested changes
Jan 26, 2022
platform-bukkit/src/main/java/net/kyori/adventure/platform/bukkit/BukkitAudiencesImpl.java
Outdated
Show resolved
Hide resolved
|
Would it not be easier to just lazily initialise the empty audience? It's the creation of the empty audience that is causing this issue after all. |
|
Chucking softDepend in BukkitAudiences.Builder would fix the root problem (creating BukkitAudiencesImpl before calling softDepend) rather than the symptom, but both fixes would work. Let me know what fix to implement and I'll update the pr. |
|
@TehBrian would you mind making both changes? So, moving the soft depend method and making the empty audience lazily initialised? Sorry for the annoyance :p |
zml2008
approved these changes
Feb 4, 2022
This was referenced Feb 28, 2022
Merged
Merged
This was referenced Mar 8, 2022
This was referenced Mar 21, 2022
This was referenced Apr 13, 2022
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.