Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.18 support #67

Merged
merged 2 commits into from Dec 2, 2021
Merged

Add 1.18 support #67

merged 2 commits into from Dec 2, 2021

Conversation

Foorcee
Copy link
Contributor

@Foorcee Foorcee commented Nov 30, 2021

Fixes #66

[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.BukkitAudience$$Lambda$4769/0x0000000801aa9440
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$Chat@374caafe
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$Chat@289b4bff
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.BukkitAudience$$Lambda$4782/0x0000000801ab0298
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.BukkitAudience$$Lambda$4783/0x0000000801ab04b8
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$ActionBar_1_17@167e02b3
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$ActionBar@454f6930
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$ActionBarLegacy@2641708a
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.BukkitAudience$$Lambda$4787/0x0000000801ab1b20
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$Title_1_17@10199ab2
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$Title@7430cf7d
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$SoundWithCategory@26cce560
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$Sound@60864b19
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$EntitySound@1d9c582c
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$BookPost1_13@35b1d8a2
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$Book1_13@1d4fca84
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$BookPre1_13@76aa21e3
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.viaversion.ViaFacet$BossBar$Builder@1b8aa1f0
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.viaversion.ViaFacet$BossBar$Builder1_9_To_1_15@100402ac
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$BossBar$Builder@7bd3f6ad
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$BossBarBuilder@6e0cf94f
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$BossBarWither$Builder@c1f7adf
[18:01:54] [Server thread/INFO]: Skipped facet: net.kyori.adventure.platform.viaversion.ViaFacet$TabList@23269398
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.PaperFacet$TabList@47f7bf31
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.CraftBukkitFacet$TabList@72f21dfd
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$TabList@b7b3251
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$CommandSenderPointers@4368c7b2
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$ConsoleCommandSenderPointers@7299b553
[18:01:54] [Server thread/INFO]: Added facet: net.kyori.adventure.platform.bukkit.BukkitFacet$PlayerPointers@7caa8bdc

@AlessioGr
Copy link

Hover & click messages did not work with 1.18 on my plugin. I tried out this PR, and now it works again. Thank you!

@Phoenix616
Copy link

I mean I don't want to be a stickler for method naming in other people's projects but it seems odd to name those methods searchMethod while all others are named way more optimistically with the findXyz pattern 🙈

@zml2008 zml2008 self-assigned this Dec 2, 2021
@MiniDigger
Copy link
Member

love the renovate notifications, look at all these people not upgrading to platforms that natively support adventure, s m h

@AlessioGr
Copy link

love the renovate notifications, look at all these people not upgrading to platforms that natively support adventure, s m h

Oh, I would love to switch to a native platform once https://www.spigotmc.org/resources/ is dead and not used by 90% of people anymore 🥲

@MiniDigger
Copy link
Member

ssssssh, am working on it! 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minecraft 1.18 not supported
7 participants