Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit dependency to 0.29 #244

Merged
merged 3 commits into from Mar 28, 2024
Merged

Conversation

Rexagon
Copy link
Contributor

@Rexagon Rexagon commented Dec 6, 2023

Tried to update winit to a new version. All the tutorials and examples were checked only on Linux with X11, so it’s better to check that it doesn’t break in other environments.

Changes in winit that affected the project:

  • ControlFlow::Exit was moved to EventLoopWindowTarget::exit().
  • EventLoop::new now return Result<Self, EventLoopError>.
  • EventLoop::run() -> ! has been replaced by EventLoop::run() -> Result<(), EventLoopError>.
  • EventLoopWindowTarget::exiting() can be used instead of a separate destroying flag.
  • Requesting redraw on Event::AboutToWait (EventLoop 3.0 Changes rust-windowing/winit#2900).
  • WindowEvent::KeyboardInput now contains a KeyEvent (instead of KeyboardInput).
  • VirtualKeyCode is now the Key enum.

Changes in raw-window-handle (0.6) that affected the project:

  • HasRawDisplayHandle, HasRawWindowHandle were replaced with HasDisplayHandle and HasWindowHandle.
  • Getting display or window handle is now fallible (ends up in the unimplemented branch, this is probably wrong).

(Amazing bindings btw, thank you very much)

@Rexagon Rexagon changed the title Update winit dependency to 0.29 (#242) Update winit dependency to 0.29 Dec 6, 2023
@Rexagon
Copy link
Contributor Author

Rexagon commented Feb 5, 2024

Finally managed to test this PR on Linux+Wayland, Windows and MacOS. All the tutorials and examples are working as expected.

@KyleMayes KyleMayes merged commit 3dc6c0e into KyleMayes:master Mar 28, 2024
@KyleMayes
Copy link
Owner

Thank you for your contribution!
Sorry for the long delay in getting it merged.
I'm working through the PRs and issues in this repository, I hope to have a new release out Soon™️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants