chore: bump ethers to 5.6.8 #887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Noticing some weird behaviour on the leaderboard, though. We might need to verify if everything works accordingly.
|
|
Kwenta/kwenta-private#479 should be fixed first to avoid the ENS issue, this one is on hold until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump ethers package to latest 5.6.8 which fixes a serious BN.js bug incorrectly computing hexstring, see ethers-io/ethers.js#3017
Additionally, package updates adds optimism to networks and provider; plus ENS avatar issues are being fixed resulting in ENS names with avatars now showing up correctly on the leaderboard.
Related issue
Motivation and Context
Upgrade ethers package to latest version
How Has This Been Tested?
Locally build with latest ethers package, checked all pages working correctly, closed an position successfully on OP L2 Mainnet.
Screenshots (if appropriate):