Skip to content
This repository has been archived by the owner on Dec 5, 2023. It is now read-only.

backend: Add api endpoints for measurements based on timestamps #2

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

Glukoosi
Copy link
Collaborator

No description provided.

@Kumikurre
Copy link
Owner

Kumikurre commented Nov 23, 2020

I think we could utilize this kind of enpoint in the frontend:

router.GET("/temp_measurements/from/:start_time/to/:end_time", routes.GetTempMeasurements)

or even simpler:

router.GET("/temp_measurements/from/:start_time", routes.GetTempMeasurements)

Notice that no mention if device in those proposals. Othen than that request, the diff looks very good to me

@Glukoosi
Copy link
Collaborator Author

I think we could utilize this kind of enpoint in the frontend:

router.GET("/temp_measurements/from/:start_time/to/:end_time", routes.GetTempMeasurements)

or even simpler:

router.GET("/temp_measurements/from/:start_time", routes.GetTempMeasurements)

Notice that no mention if device in those proposals. Othen than that request, the diff looks very good to me

router.GET("/temp_measurements_all/from/:start_time/to/:end_time", routes.GetTempMeasurements)
and
router.GET("/temp_measurements_all/from/:start_time", routes.GetTempMeasurements)

are now implemented (had to add _all 'cause gin limitations) gin-gonic/gin#1301

@Kumikurre
Copy link
Owner

Great work. I'll merge this

@Kumikurre Kumikurre merged commit e9eb07b into main Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants