Remove absolute placeholders from tables with break-inside: avoid

Related to #2134.
Kozea · May 11, 2024 · 22b35bb · 22b35bb
1 parent ed249da
commit 22b35bb
Show file tree

Hide file tree

Showing 3 changed files with 100 additions and 5 deletions.
diff --git a/tests/layout/test_table.py b/tests/layout/test_table.py
@@ -2800,6 +2800,100 @@ def test_table_empty_body(rows_expected, thead, tfoot, content):
         assert rows == rows_expected[i]
 
 
+def test_table_group_break_inside_avoid_absolute():
+    # Test regression: https://github.com/Kozea/WeasyPrint/issues/2134
+    html = '''
+      <style>
+        @page { size: 5cm }
+        tbody { break-inside: avoid; line-height: 2cm }
+        div { position: absolute }
+      </style>
+      <table>
+        <tbody><tr><td>a</td></tr></tbody>
+        <tbody><tr>
+          <td><div>a<br>b</div></td>
+          <td>a<br>b</td>
+        </tr></tbody>
+      </table>
+    '''
+    page1, page2 = render_pages(html)
+
+    html, = page1.children
+    body, = html.children
+    table_wrapper, = body.children
+    table, = table_wrapper.children
+    group, = table.children  # Only first group
+
+    html, = page2.children
+    body, = html.children  # No absolute div here
+    table_wrapper, = body.children
+    table, = table_wrapper.children
+    group, = table.children  # Only second group
+
+
+def test_table_row_break_inside_avoid_absolute():
+    # Test regression: https://github.com/Kozea/WeasyPrint/issues/2134
+    html = '''
+      <style>
+        @page { size: 5cm }
+        tr { break-inside: avoid; line-height: 2cm }
+        div { position: absolute }
+      </style>
+      <table>
+        <tr><td>a</td></tr>
+        <tr>
+          <td><div>a<br>b</div></td>
+          <td>a<br>b</td>
+        </tr>
+      </table>
+    '''
+    page1, page2 = render_pages(html)
+
+    html, = page1.children
+    body, = html.children
+    table_wrapper, = body.children
+    table, = table_wrapper.children
+    group, = table.children
+    row, = group.children  # Only first row
+
+    html, = page2.children
+    body, = html.children  # No absolute div here
+    table_wrapper, = body.children
+    table, = table_wrapper.children
+    group, = table.children
+    row, = group.children  # Only second row
+
+
+def test_table_break_inside_avoid_absolute():
+    # Test regression: https://github.com/Kozea/WeasyPrint/issues/2134
+    html = '''
+      <style>
+        @page { size: 5cm }
+        body { line-height: 2cm }
+        table { break-inside: avoid }
+        div { position: absolute }
+      </style>
+      <p>text</p>
+      <table>
+        <tr>
+          <td><div>a<br>b</div></td>
+          <td>a<br>b</td>
+        </tr>
+      </table>
+    '''
+    page1, page2 = render_pages(html)
+
+    html, = page1.children
+    body, = html.children
+    p, = body.children
+    line, = p.children
+    text, = line.children
+    assert text.text == 'text'
+
+    html, = page2.children
+    body, = html.children  # No absolute div here
+
+
 def test_table_break_children_margin():
     # Test regression: https://github.com/Kozea/WeasyPrint/issues/1254
     html = '''

diff --git a/weasyprint/css/properties.py b/weasyprint/css/properties.py
@@ -313,7 +313,6 @@
     'bottom',
     'break_after',
     'break_before',
-    'break_inside',
     'clear',
     'counter_increment',
     'counter_reset',

diff --git a/weasyprint/layout/table.py b/weasyprint/layout/table.py
@@ -15,7 +15,7 @@ def table_layout(context, table, bottom_space, skip_stack, containing_block,
     """Layout for a table box."""
     from .block import (  # isort:skip
         avoid_page_break, block_container_layout, block_level_page_break,
-        find_earlier_page_break, force_page_break)
+        find_earlier_page_break, force_page_break, remove_placeholders)
 
     has_header = table.children and table.children[0].is_header
     has_footer = table.children and table.children[-1].is_footer
@@ -209,6 +209,8 @@ def group_layout(group, position_y, bottom_space, page_is_empty,
             if resume_at and not page_is_empty:
                 if avoid_page_break(row.style['break_inside'], context):
                     resume_at = {index_row: {}}
+                    remove_placeholders(
+                        context, new_row_children, absolute_boxes, fixed_boxes)
                     break
 
             row = row.copy_with_children(new_row_children)
@@ -338,9 +340,8 @@ def group_layout(group, position_y, bottom_space, page_is_empty,
         if resume_at and not original_page_is_empty and (
                 avoid_page_break(group.style['break_inside'], context) or
                 not new_group_children):
-            for descendant in group.descendants():
-                if descendant.footnote is not None:
-                    context.unlayout_footnote(descendant.footnote)
+            remove_placeholders(
+                context, new_group_children, absolute_boxes, fixed_boxes)
             return None, None, next_page
 
         group = group.copy_with_children(new_group_children)
@@ -599,6 +600,7 @@ def get_column_cells(table, column):
 
     avoid_break = avoid_page_break(table.style['break_inside'], context)
     if resume_at and not page_is_empty and avoid_break:
+        remove_placeholders(context, [table], absolute_boxes, fixed_boxes)
         table = None
         resume_at = None
     adjoining_margins = []