Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated build scripts to kts #2654

Merged
merged 17 commits into from May 6, 2024
Merged

Migrated build scripts to kts #2654

merged 17 commits into from May 6, 2024

Conversation

shanshin
Copy link
Contributor

@shanshin shanshin commented Apr 25, 2024 •
edited

Resolves #2635

@shanshin shanshin changed the title Translate to kts Migrate build scripts to kts Apr 25, 2024
@shanshin shanshin changed the title Migrate build scripts to kts Migrated build scripts to kts Apr 25, 2024
@sandwwraith sandwwraith mentioned this pull request Apr 26, 2024
Closed
@shanshin shanshin requested a review from qwwdfsad April 27, 2024 17:31
sandwwraith
sandwwraith reviewed Apr 29, 2024
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've published library from this branch to sonatype, and it seem to work correctly (at least it is resolved by integration-test). You can also compare contents of sonatype repo manually, if you want to.

buildSrc/src/main/kotlin/dokka-conventions.gradle.kts Outdated Show resolved Hide resolved
buildSrc/src/main/kotlin/native-targets-conventions.gradle.kts Outdated Show resolved Hide resolved
buildSrc/src/main/kotlin/publishing-conventions.gradle.kts Outdated Show resolved Hide resolved
buildSrc/src/main/kotlin/publishing-conventions.gradle.kts Outdated Show resolved Hide resolved
buildSrc/src/main/kotlin/source-sets-conventions.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Outdated Show resolved Hide resolved
build.gradle.kts Show resolved Hide resolved
integration-test/settings.gradle.kts Show resolved Hide resolved
@shanshin shanshin requested a review from sandwwraith May 6, 2024 12:05
@shanshin shanshin merged commit 5aa1032 into dev May 6, 2024
4 checks passed
@shanshin shanshin deleted the kts-buildscripts branch May 6, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdvrieze pdvrieze pdvrieze left review comments

@sandwwraith sandwwraith sandwwraith approved these changes

@qwwdfsad qwwdfsad Awaiting requested review from qwwdfsad

Assignees

@shanshin shanshin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shanshin @sandwwraith @pdvrieze