-
Notifications
You must be signed in to change notification settings - Fork 614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using an integer as the class/case discriminator in polymorphic serialization #2587
base: dev
Are you sure you want to change the base?
Commits on Feb 17, 2024
-
Initially add the annotations and refactor the serializers, descripto…
…rs, and serializers modules for serializing type numbers in polymorphic serialization without any support from the serialization plugin yet
Configuration menu - View commit details
-
Copy full SHA for 4ed38d7 - Browse repository at this point
Copy the full SHA 4ed38d7View commit details
Commits on Feb 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d8e06b2 - Browse repository at this point
Copy the full SHA d8e06b2View commit details -
Remove unused code related to storing the map from polymorphic subcla…
…sses to polymorphic numbers See commit 3289fb2.
Configuration menu - View commit details
-
Copy full SHA for f80d7a8 - Browse repository at this point
Copy the full SHA f80d7a8View commit details
Commits on Feb 20, 2024
-
Locate and fix a bug caused by lazy evaluation brought early in `Seal…
…edSerializer` that causes the tests to break
Configuration menu - View commit details
-
Copy full SHA for 5834dcd - Browse repository at this point
Copy the full SHA 5834dcdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c24ef0 - Browse repository at this point
Copy the full SHA 5c24ef0View commit details
Commits on Feb 24, 2024
-
Add some tests for serial polymorphic numbers which fail for now
Some miscellaneous changes: 1. Add a `getSerialPolymorphicNumberByBaseClass` function in `SerialDescriptor` to throw the appropriate exception. 1. Add `defaultDeserializerForNumber` which was missing in `PolymorphicModuleBuilder`.
Configuration menu - View commit details
-
Copy full SHA for 51d9a75 - Browse repository at this point
Copy the full SHA 51d9a75View commit details
Commits on Feb 27, 2024
-
Enable Kotlin compiler bootstrap, use the corresponding SNAPSHOT vers…
…ion, and update an annotation property name The corresponding commit: huanshankeji/kotlin@9860724
Configuration menu - View commit details
-
Copy full SHA for e101ae8 - Browse repository at this point
Copy the full SHA e101ae8View commit details
Commits on Feb 28, 2024
-
Move
useSerialPolymorphicNumbers
and `serialPolymorphicNumberByBase……Class` into `PluginGeneratedSerialDescriptor` where it belongs and add some more tests in `SerialPolymorphicNumberTest` (which fail for now)
Configuration menu - View commit details
-
Copy full SHA for 1aa1354 - Browse repository at this point
Copy the full SHA 1aa1354View commit details
Commits on Mar 2, 2024
-
Mark the annotations
UseSerialPolymorphicNumbers
and `SerialPolymor……phicNumber` with `@SerialInfo` to be stored in `SerialDescriptor.annotations` and refactor related code Main changes: 1. Extract common lazy properties in `CommonSerialDescriptor` and make both `PluginGeneratedSerialDescriptor` and `SerialDescriptorImpl` inherit it. 1. Support serial polymorphic numbers with JSON's custom implementations in `AbstractJsonTreeEncoder`, `StreamingJsonEncoder`, and `DynamicObjectEncoder` while adapting the `encodePolymorphically` and `decodeSerializableValuePolymorphic` functions. 1. Revert gradle.properties since there is no need to update the compiler plugin anymore. 1. Make all tests pass in `SerialPolymorphicNumberTest` and copy it into the Protobuf module and adapt.
Configuration menu - View commit details
-
Copy full SHA for bcae134 - Browse repository at this point
Copy the full SHA bcae134View commit details -
Configuration menu - View commit details
-
Copy full SHA for c53d324 - Browse repository at this point
Copy the full SHA c53d324View commit details -
Review all changes since commit 41c0bb1, improving some code and comm…
…ents and reverting some unnecessary changes
Configuration menu - View commit details
-
Copy full SHA for 4973f07 - Browse repository at this point
Copy the full SHA 4973f07View commit details
Commits on Mar 12, 2024
-
Clarify the misconception in the test for `defaultDeserializerForNumb…
…er` and make it work See Kotlin#2598.
Configuration menu - View commit details
-
Copy full SHA for 23c385c - Browse repository at this point
Copy the full SHA 23c385cView commit details