Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Easier to configure ProGuard rules #1721
Easier to configure ProGuard rules #1721
Changes from 8 commits
80609f2
d882894
3fce533
44cf952
4f8c58d
f58f8f1
48de870
0fae562
e493bd2
0d4968a
d270a1c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please indicate in this comment that this rule applies to default (Companion) and named companions. This makes the rules easier to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a small side effect, this rule will keep the
serializer
function for all nested classes, but this is a very rare case and this rule is the easiest way to support named companions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It actually doesn't, because of the pattern matching. It will pass beyond the
if
check, but the<3>
in-keepclassmembers class <1>$<3>
will be the static field name defined in theif
condition.I tried with the following:
This would translate to
-keepclassmembers class HasSimpleCompanion$Companion
, not-keepclassmembers class HasSimpleCompanion$Test
. There is no static field for normal inner classes.serializer
is still removed (answer()
is used so the full class isn't removed) as shown in theusage.txt
output: