Rewrite the implementation of the linked list for JobSupport
#4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
dk-remove-linked-list
branch
from
176b417
to
9b9148c
Compare
|
@qwwdfsad, could you help with optimizing the memory consumption? Not requesting a proper review yet because I know already the code is messy, I just expect it to get even messier during memory consumption optimization. |
dkhalanskyjb
force-pushed
the
dk-remove-dcss-2
branch
from
4858fc5
to
494d8ca
Compare
With this change, `JobSupport` uses only a small and well-defined portion of the functionality `LockFreeLinkedList` provides, which makes it easier to replace the list implementation.
In exchange, now, removal is linear in the size of number of registered handlers instead of being amortized constant.
dkhalanskyjb
force-pushed
the
dk-remove-linked-list
branch
from
03a42b9
to
7fe8543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3886
One of the steps for #3887
A draft because
JobSupport.