Install Dispatchers.Default on native when creating new context for coroutine builders when there is no ContinuationInterceptor there
#4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… coroutine builders when there is no `ContinuationInterceptor` there Fixes #4074
| assertSame(Dispatchers.Default, newContextDispatcher(Dispatchers.Unconfined, Dispatchers.Default)) | ||
| assertSame(Dispatchers.Unconfined, newContextDispatcher(Dispatchers.Default, Dispatchers.Unconfined)) | ||
| assertSame(Dispatchers.Unconfined, newContextDispatcher(Dispatchers.Unconfined, Dispatchers.Unconfined)) | ||
| } |
There was a problem hiding this comment.
I think we also need to check the user-visible bug directly, like what you have in your reproducer:
runTest {
val job = Job()
val scope = CoroutineScope(job + coroutineContext[CoroutineExceptionHandler]!!)
scope.launch(Dispatchers.Default) {
assertSame(Dispatchers.Default, coroutineContext[ContinuationInterceptor])
}
scope.launch {
assertSame(Dispatchers.Default, coroutineContext[ContinuationInterceptor])
}
job.complete()
job.join()
}There was a problem hiding this comment.
Sure, added additional test with launch
dkhalanskyjb
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4074