Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native targets to the smokeTest project in integration tests. #3974

Closed
wants to merge 2 commits into from

Conversation

mvicsokolova
Copy link
Contributor

@mvicsokolova mvicsokolova commented Dec 6, 2023

As there were no native targets in smokeTest, the problem with lacking atomicfu dependency (KT-64111) was not addressed in time.

Could not find "org.jetbrains.kotlinx:atomicfu-cinterop-interop" in [/playground/compileOnly-native,/.konan/klib, /.konan/kotlin-native-prebuilt-macos-x86_64-1.9.21/klib/common, /.konan/kotlin-native-prebuilt-macos-x86_64-1.9.21/klib/platform/linux_x64]

The bug was revealed after release of kotlinx.coroutines with atomicfu-gradle-plugin 0.23.1. Coroutines enabled Native IR transformation, and for this mode atomicfu-gradle-plugin only provided compile dependency to atomicfu, though implementation dependency was still necessary because coroutines depend on the API from kotlinx.atomicfu.locks package: like SynchronizedObject, withLock() etc.

I guess we can merge this PR after update to atomicfu 0.23.2 with the fix.

As there were no native targets in smokeTest, the problem with lacking atomicfu dependency (KT-64111) was not addressed in time. The bug was revealed after  release of kotlinx.coroutines with atomicfu-gradle-plugin 0.23.1. Coroutines enabled Native IR transformation, and for this mode atomicfu-gradle-plugin only provided compile dependency to atomicfu, though implementation dependency was still necessary.
@mvicsokolova mvicsokolova marked this pull request as ready for review December 6, 2023 14:57
@mvicsokolova
Copy link
Contributor Author

And now integration tests fail with the expected error:

:smokeTest:compileKotlinLinuxArm64
[16:08:54 ](https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxCoroutines_BuildAggregated/4411658?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true&showLog=4411657_69120_69120&logFilter=debug&logView=flowAware)    e: Could not find "org.jetbrains.kotlinx:atomicfu-cinterop-interop" in [Z:\BuildAgent\work\44ec6e850d5c63f0\integration-testing, C:\Users\builduser\.konan\klib, C:\Users\builduser\.konan\kotlin-native-prebuilt-windows-x86_64-1.9.21\klib\common, C:\Users\builduser\.konan\kotlin-native-prebuilt-windows-x86_64-1.9.21\klib\platform\linux_arm64]
[16:08:54 ](https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxCoroutines_BuildAggregated/4411658?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true&showLog=4411657_69121_69121&logFilter=debug&logView=flowAware)    e: Could not find "org.jetbrains.kotlinx:atomicfu-cinterop-interop" in [Z:\BuildAgent\work\44ec6e850d5c63f0\integration-testing, C:\Users\builduser\.konan\klib, C:\Users\builduser\.konan\kotlin-native-prebuilt-windows-x86_64-1.9.21\klib\common, C:\Users\builduser\.konan\kotlin-native-prebuilt-windows-x86_64-1.9.21\klib\platform\linux_arm64]
[16:08:54 ](https://teamcity.jetbrains.com/buildConfiguration/KotlinTools_KotlinxCoroutines_BuildAggregated/4411658?hideTestsFromDependencies=false&hideProblemsFromDependencies=false&expandBuildProblemsSection=true&expandBuildChangesSection=true&showLog=4411657_69123_69123&logFilter=debug&logView=flowAware)  Execution failed for task ':smokeTest:compileKotlinLinuxArm64'. org.jetbrains.kotlin.backend.konan.KonanCompilationException: Compilation finished with errors

@dkhalanskyjb
Copy link
Contributor

Closed in favor of #3996

@dkhalanskyjb dkhalanskyjb deleted the smokeTest-configuration branch December 21, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants