Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add issue templates #3560

Merged
merged 2 commits into from Dec 28, 2022
Merged

Add issue templates #3560

merged 2 commits into from Dec 28, 2022

Conversation

dkhalanskyjb
Copy link
Collaborator

No description provided.

@@ -0,0 +1,46 @@
---
name: Design considerations
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Design" in the sense of API semantics is something we got used to, but this term is unlikely to be widespread and approachable to others.

Maybe "Feature request" or "Feature or behaviour request" will suit better?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already "feature request" for new features, see feature_request.md. "Design considerations" is for changing the existing things, like "Dispatchers.Unconfined shouldn't use an event loop", or something like #2860. Deeply technical discussions about issues with things that are already there.

name: Feature request
about: We're missing something?
title: ''
labels: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be enhancement, but no hard opinion on this one

Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, amazing attention to details (i.e. examples and non-examples) 🔥

@dkhalanskyjb dkhalanskyjb merged commit bb4dcde into master Dec 28, 2022
@dkhalanskyjb dkhalanskyjb deleted the add-issue-templates branch December 28, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants