Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests with real source of the time on Java's Windows to preve… #3516

Merged
merged 2 commits into from Nov 3, 2022

Conversation

qwwdfsad
Copy link
Member

…nt flakiness

We still want to test real code, not virtualized mocked clocks, but Windows itself is virtualized on our TeamCity, making Java's parker resolution really low and unstable for such tests

…nt flakiness

We still want to test real code, not virtualized mocked clocks, but Windows itself is
virtualized on our TeamCity, making Java's parker resolution really low and unstable for such tests
@qwwdfsad
Copy link
Member Author

Let's see if it's os.name or teamcity.agent.jvm.os.name though

Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you happen to know what difference Java makes here? Why don't we observe the same on Native?

kotlinx-coroutines-core/jvm/test/TestBase.kt Outdated Show resolved Hide resolved
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
@qwwdfsad
Copy link
Member Author

qwwdfsad commented Nov 2, 2022

Java uses WaitForSingleObject that on its own happens to have resolution problems (see #3301 (comment), dated back to 1998!), it seems like in virtualized environments it just gets exponentially worse.

No idea why it is not the issue on Windows K/N though, probably different OS-level API is used

@qwwdfsad qwwdfsad merged commit 4e29357 into develop Nov 3, 2022
@qwwdfsad qwwdfsad deleted the disable-flaky-windows-tests branch November 3, 2022 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants