Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test project #3307
Integration test project #3307
Changes from 12 commits
ba4a93d
f204b21
0f9d689
f68953a
9d0ac0e
8e09712
ec04fa9
3754a2c
fa1ac5f
a51ab66
5b42bd7
d8bc9e4
66af8a0
2669b2c
ad5425f
67936ac
d50c23d
fa41006
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, that's an issue.
This flag control the functionality in
integration-testing/src/debugAgentTest/kotlin/PrecompiledDebugProbesTest.kt
that allows us to replaceDebugProbesKt.bin
, a file in the repository, with a new version. I'm sure this functionality is now broken. We should either fix this or adapt in some other way. @qwwdfsad, do we still need-Poverwrite.probes
? Does anyone rely but us on this, or can we provide a more fitting interface? Also, is the comment below still relevant (from the file with the test)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is indeed redundant.
Right. @mvicsokolova please ensure that
./gradlew debugAgentTest -Poverwrite.probes=true
properly works. For now it fails withFileNotFoundException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that,
./gradlew publishToMavenLocal
+cd integration-testing
+./gradlew debugAgentTest
fails locally atPrecompiledDebugProbesTest
. It shouldn't be be the case, please investigate